Member $wgExtensionMessagesFiles ['HeaderTabsMagic']

implement in tab parsing code instead... but problems like nowiki (2011-12-12, ofb)

Add a note about maintenance/namespaceDupes.php

Reformat documentation.

Deprecate the setting and ultimately remove it from Core.

On the long run, it would be nice to put categories etc into a separate structure, or at least parse only the contents of comments in the scripts.

Member APCUBagOStuff::decr ($key, $value=1)

When we only support php 7 or higher remove this hack

Member APCUBagOStuff::incr ($key, $value=1)

When we only support php 7 or higher remove this hack

Member ApiParseTest::setupSkin ()

Should this code be in MediaWikiTestCase or something?

Member ApiQueryConfiguredpages::getAllowedParams ()

Once support for MediaWiki < 1.25 is dropped, just use ApiBase::PARAM_HELP_MSG directly

Member ApiQueryOldreviewedpages::getAllowedParams ()

Once support for MediaWiki < 1.25 is dropped, just use ApiBase::PARAM_HELP_MSG directly

Member ApiQueryReviewedpages::getAllowedParams ()

Once support for MediaWiki < 1.25 is dropped, just use ApiBase::PARAM_HELP_MSG directly

Member ApiReview::getAllowedParams ()

Once support for MediaWiki < 1.25 is dropped, just use ApiBase::PARAM_HELP_MSG directly

Member ApiStabilizeGeneral::getAllowedParams ()

Once support for MediaWiki < 1.25 is dropped, just use ApiBase::PARAM_HELP_MSG directly

Member ApiStabilizeProtect::getAllowedParams ()

Once support for MediaWiki < 1.25 is dropped, just use ApiBase::PARAM_HELP_MSG directly

Member ApiUpload::handleStashException ($e)

Internationalize the exceptions then get rid of this

Parameters

Exception $e

Returns: StatusValue

Class ApiUploadTest

Port the other Upload tests, and other API tests to this framework

Broken test, reports false errors from time to time. See https://phabricator.wikimedia.org/T28169

This is pretty sucky... needs to be prettified.

Class ApiWatchTest

This test suite is severly broken and need a full review

Class Article

Move and rewrite code to an Action class

Member Article::confirmDelete ($reason)

FIXME: Move to another file?

Parameters

string $reason Prefilled reason

Member Article::fetchContentObject ()

When is this null?

Member Article::getRobotPolicy ($action, $pOutput=null)

actions other than 'view'

Member AutoAuthSetup ()

If you want to make AutoAuthSetup() work in an AuthManager world, what you need to do is figure out how to do it with a SessionProvider instead of the hackiness below. You'll probably want an ImmutableSessionProviderWithCookie subclass where provideSessionInfo() does the first part of LdapAutoAuthentication::Authenticate() (stop before the $localId bit).

Namespace Avro

Implement JSON encoding, as is required by the Avro spec.

Refactor AvroNamedSchema to use an AvroName instance to store name information.

Member AvroDataIO::SYNC_SIZE

make this value configurable

Member AvroField::__construct ($name, $schema, $is_type_from_schemata, $has_default, $default, $order=null)

Check validity of $default value

Check validity of $order value

Member AvroStringIO::read ($len)

test for fencepost errors wrt updating current_index

Class AvroValidatorTest

Test methods in this call should be split into a method and a dataprovider.

Member BackupDumper::backupDb ()

Fixme: the –server parameter is currently not respected, as it doesn't seem terribly easy to ask the load balancer for a particular connection by name.

Returns: IDatabase

Class BitmapMetadataHandler

Other image formats.

Member BitmapMetadataHandler::Tiff ($filename)

Add XMP support, so this function actually makes sense to put here.

Member Block::getTargetAndType ()

FIXME: This should be an integral part of the Block member variables

Member BSApiWikiPageTasks::getTitleFromTaskData ($oTaskData)

: Maybe have this logic in "parent::getTitle" altogether

Member BSUserLoginMobileTemplate::execute ()

Refactor this into parent template

Member CacheTime::isDifferentRevision ($id)

We always return false if $this->getCacheRevisionId() is null; this prevents invalidating the whole parser cache when this change is deployed. Someday that should probably be changed.

Class Category

Move some stuff from CategoryPage.php to here, and use that.

Member CategoryFinder::seed ($articleIds, $categories, $mode= 'AND', $maxdepth=-1)

FIXME: $categories/$mode

File cdb.php

document

Page Changes in PHPUnit 4.2

will now be reported as risky when the–disallow-todo-testsoption is used orbeStrictAboutTodoAnnotatedTests=true

is set in the configuration file
TheatLeast()andatMost()` invocation count matchers were added

Page Changes in PHPUnit 4.3

` annotated tests are counted twice

Class ChangesListSpecialPage

Way too many public functions, most of them should be protected

Member ChangesListSpecialPage::getExtraOptions ($opts)

This should handle options returned by getDefaultOptions().

Not called by anything in this class (but is in subclasses), should be called by something… doHeader() maybe?

Member ChangeTags::MAX_DELETE_USES

Use the job queue for tag deletion to avoid this restriction

Class ChangeTagsLogItem

 Abstract out a base class for this and RevDelLogItem, similar to the RevisionItem class but specifically for log items. Since
1.25

Member Cite::DEFAULT_GROUP

document

Member Cite::MAX_STORAGE_LENGTH

Find a way to retrieve this information from the DBAL

Member Content::getTextForSearchIndex ()

Test that this actually works

Make sure this also works with LuceneSearch / WikiSearch

Member Content::getWikitextForTransclusion ()

Allow native handling, bypassing wikitext representation, like for includable special pages.

Allow transclusion into other content models than Wikitext!

Used in WikiPage and MessageCache to get message text. Not so nice. What should we use instead?!

Member ContentHandler::getAutoDeleteReason (Title $title, &$hasHistory)

 &$hasHistory is extremely ugly, it's here because WikiPage::getAutoDeleteReason() and Article::generateReason() have it / want it.

Member ContentHandler::getFieldsForSearchIndex (SearchEngine $engine)

Expose title, redirect, namespace, text, source_text, text_bytes field mappings here. (see T142670 and T143409)

Member ContribsPager::formatRow ($row)

 This would probably look a lot nicer in a table. Parameters

  
    object $row 
  
  

Returns
string

Member Cookie::validateCookieDomain ($domain, $originDomain=null)

fixme fails to detect 3-letter top-level domains

fixme fails to detect 2-letter top-level domains for single-domain use (probably not a big problem in practice, but there are test cases)

Member CoreTagHooks::gallery ($content, $attributes, $parser)

break Parser::renderImageGallery out here too.

Member DatabaseSqliteTest::testUpgrades ()

Currently only checks list of tables

Member DataValues::requireArrayFields ($data, array $fields)

: this should be removed once we got rid of all the static newFromArray() methods.

Member DataValues::GLOBE_MOON

Move this constant next to GlobeCoordinateValue::GLOBE_EARTH?

Class DateFormatter

preferences, OutputPage

Member DBSiteStore::__construct (LoadBalancer $dbLoadBalancer)

: inject some kind of connection manager that is aware of the target wiki, instead of injecting a LoadBalancer.

Member DeletedContribsPager::formatRevisionRow ($row)

 This would probably look a lot nicer in a table. Parameters

  
    stdClass $row 
  
  

Returns
string

Member DeletedContribsPager::formatRow ($row)

 This would probably look a lot nicer in a table. Parameters

  
    stdClass $row 
  
  

Returns
string

File deleteOrphanedRevisions.php

More efficient cleanup of text records

Class DifferenceEngine

document

Member DifferenceEngine::generateTextDiffBody ($otext, $ntext)

move this to TextDifferenceEngine, make DifferenceEngine abstract. At some point.

Class DifferenceEngineTest

tests for the rest of DifferenceEngine!

Class DiffFormatter

document

Member DummySerializeErrorContentHandler::supportsDirectApiEditing ()

Should this be in the parent class?

File dumpMessages.php

Make this more useful, right now just dumps $wgContLang

Member EchoAttributeManager::getNotificationSection ($notificationType)

 add a unit test case Parameters

  
    string $notificationType 
  
  

Returns
string

Member EchoDiscussionParser::interpretDiff ($changes, $username, Title $title=null)

Expand recognisable actions.

Class EchoFilteredSequentialIterator

name?

Member EchoNotificationMapperTest::testInsert ()

write this test

Member EditPage::importFormData (&$request)

 Check if the desired model is allowed in this namespace, and if a transition from the page's current model to the new model is allowed.

Member EditPage::internalAttemptSave (&$result, $bot=false)

 FIXME: This interface is TERRIBLE, but hard to get rid of due to various error display idiosyncrasies. There are also lots of cases where error metadata is set in the object and retrieved later instead of being returned, e.g. AS_CONTENT_TOO_BIG and AS_BLOCKED_PAGE_FOR_USER. All that stuff needs to be cleaned up some time.

Class Elastica

Add some settings examples to code

Member EnhancedChangesList::makeCacheGroupingKey (RCCacheEntry $cacheEntry)

use rc_source to group, if set; fallback to rc_type

Member EnhancedChangesListTest::testEndRecentChangesList ()

more tests for actual formatting, this is more of a smoke test

Member EnhancedChangesListTest::testRecentChangesLine ()

more tests

Class EraseArchivedFile

Maybe add some simple logging

Member Exif::__construct ($file, $byteOrder= '')

 FIXME: The following are broke: SubjectArea. Need to test the more obscure tags. DigitalZoomRatio = 0/0 is rejected. need to determine if that's valid. Possibly should treat 0/0 = 0. need to read exif spec on that.

Member ExifBitmapHandler::getRotationForExif ($data)

FIXME: Orientation can include flipping as well; see if this is an issue!

Member ExtensionProcessor::extractConfig1 (array $info)

In the future, this should be done via Config interfaces

Member ExtensionProcessor::extractConfig2 (array $info, $dir)

In the future, this should be done via Config interfaces

Class FactoryMethod

Search method in file contents for func_get_args() to replace factoryVarArgs.

Class FormOptions

This badly needs some examples and tests :) The usage in SpecialRecentchanges class is a good ersatz in the meantime.

Class GadgetDefinitionValidator

maybe this should use a formal JSON schema validator or something

Member getApiCode ()

: Kill this case along with ApiBase::$messageMap

Member GIFHandler::getImageArea ($image)

Add unit tests

Class Hamcrest

Replace $property with a matcher and iterate all property names.

Member HeaderTabs::replaceFirstLevelHeaders (&$parser, &$text, $aboveandbelow)

handle NOTABTOC, TABTOC, FORCETABTOC here (2011-12-12, ofb)

handle TOC, FORCETOC, NOTOC here (2011-12-12, ofb)

insert the toc after the first paragraph, maybe we can steal the location from formatHeadings despite the changed html? (2011-12-12, ofb)

see if we can't add the SMW factbox stuff back in (2011-12-12, ofb)

handle NOEDITTAB here (2011-12-12, ofb)

Member HeaderTabsHooks::addHTMLHeader (&$out)

 we might be able to only load our js and styles if we are rendering tabs, speeding up pages that don't use it? but what about cached pages? (2011-12-12, ofb)

Member HistoryPager::diffButtons ($rev, $firstInList)

Move title texts to javascript

Member HistoryPager::historyLine ($row, $next, $notificationtimestamp=false, $latest=false, $firstInList=false)

document some more, and maybe clean up the code (some params redundant?)

Member Html::inlineScript ($contents)

do some useful escaping as well, like if $contents contains literal "</script>" or (for XML) literal "]]>".

Class HTMLForm

Document 'section' / 'subsection' stuff

Member HTMLForm::displaySection ($fields, $sectionName= '', $fieldsetIDPrefix= '', &$hasUserVisibleFields=false)

Document

Member HTMLForm::setMessagePrefix ($p)

Currently only used for the "<fieldset>" legend on forms with multiple sections; should be used elsewhere?

Member HTMLForm::setSubmitID ($t)

 FIXME: Integrity of $t is not validated Returns
HTMLForm $this for chaining calls (since 1.20)

Class HTMLSelectAndOtherField

FIXME: If made 'required', only the text field should be compulsory.

Member Http::isValidURI ($uri)

FIXME this is wildly inaccurate and fails to actually check most stuff

Class HttpErrorTest

tests for HttpError::report

Class HttpStatus

document

File IEContentAnalyzer.php

Define the exact license of this file.

Class IEUrlExtensionTest

tests below for findIE6Extension should be split into... ...a dataprovider and test method.

Member ImagePage::makeMetadataTable ($metadata)

FIXME: Bad interface, see note on MediaHandler::formatMetadata().

Class IPTest

Test methods in this call should be split into a method and a dataprovider.

Member Issue1468Test::testFailure ()

Implement this test

Class JavaScriptContentHandler

Create a ScriptContentHandler base class, do highlighting stuff there?

Class JpegMetadataExtractorTest

 Could use a test of extended XMP segments. Hard to find programs that create example files, and creating my own in vim propbably wouldn't serve as a very good "test". (Adobe photoshop probably creates such files but it costs money). The implementation of it currently in MediaWiki is based solely on reading the standard, without any real world test files.

Class JpegPixelFormatTest

covers tags

Member Language::convertHtml ($text, $isTitle=false)

this should get integrated somewhere sane

Member Language::formatNum ($number, $nocommafy=false)

 check if it's viable to use localeconv() for the decimal separator thing. Parameters

  
    int | float $number The string to be formatted, should be an integer or a floating point number. 
    bool $nocommafy Set to true for special numbers like dates 
  
  

Returns
string

Member Language::needsGenderDistinction ()

There may be other gender namespace than NS_USER & NS_USER_TALK in the future

Member Language::sprintfDate ($format, $ts, DateTimeZone $zone=null, &$ttl= 'unused')

handling of "o" format character for Iranian, Hebrew, Hijri & Thai?

Member Language::translateBlockExpiry ($str, User $user=null, $now=0)

 Maybe translate block durations. Note that this function is somewhat misnamed: it deals with translating the duration ("1 week", "4 days", etc), not the expiry time (which is an absolute timestamp). Please note: do NOT add this blindly, as it is used on old expiry lengths recorded in log entries. You'd need to provide the start date to match up with it.

Member LanguageAr::normalize ($s)

 FIXME: This is language-specific for now only to avoid the negative performance impact of enabling it for all languages.

Member LanguageArTest::testFormatNum ()

split into a test and a dataprovider

Class LanguageCode

Move some of the code-related static methods out of Language into this class

Member LanguageMl::normalize ($s)

 FIXME: This is language-specific for now only to avoid the negative performance impact of enabling it for all languages.

Member LanguageNlTest::testFormatNum ()

split into a test and a dataprovider

File LanguageSrTest.php

 methods in test class should be tidied:
Should be split into separate test methods and data providers
Tests for LanguageConverter and Language should probably be separate..

File LanguageUzTest.php

 methods in test class should be tidied:
Should be split into separate test methods and data providers
Tests for LanguageConverter and Language should probably be separate..

Member LanguageYue::segmentByWord ($string)

FIXME: Only do this for Han characters...

Member LanguageZh_hans::segmentByWord ($string)

FIXME: Only do this for Han characters...

Class LdapPrimaryAuthenticationProvider

 Someday someone who knows about authenticating against LDAP should write an extension that doesn't have craziness like a global "domain" variable where we have to guess at the correct value in half the entry points.

Class Linker

turn this into a legacy interface for HtmlPageLinkRenderer and similar services.

Member Linker::formatLinksInComment ($comment, $title=null, $local=false, $wikiId=null)

FIXME: Doesn't handle sub-links as in image thumb texts like the main parser

Member Linker::makeMediaLinkFile (Title $title, $file, $html= '')

Handle invalid or missing images better.

Class LinkFilter

 implement the filter. Currently these are just some functions to help maintenance/cleanupSpam.php remove links to a single specified domain. The next thing is to implement functions for checking a given page against a big list of domains.

Member LinkSearchPage::getMaxResults ()

 FIXME This special page should not use LIMIT for paging Returns
int

Class LocalFileTest

Split tests into providers and test methods

Member LogPage::getTitleLink ($type, $lang, $title, &$params)

 Document Parameters

  
    string $type 
    Language | null $lang 
    Title $title 
    array &$params 
  
  

Returns
string

File mcc.php

document

Member MediaHandler::formatMetadata ($image, $context=false)

 FIXME: This interface is not very flexible. The media handler should generate HTML instead. It can do all the formatting according to some standard. That makes it possible to do things like visual indication of grouped and chained streams in ogg container files. Parameters

  
    File $image 
    bool | IContextSource $context Context to use (optional) 
  
  

Returns
array|bool

Member MediaStatisticsPage::outputMediaType ($mediaType)

Possibly could add a message here explaining what the different types are. not sure if it is needed though.

Member MediaStatisticsPage::outputTableRow ($mime, $count, $bytes)

Check to be sure this really should have number formatting

Member MediaWiki::testSetPasswordResetFlag ()

: Because we're currently using User, which uses the global config...

Member MediaWiki::profilePreferences (User $user, IContextSource $context, &$defaultPreferences, $canIPUseHTTPS)

 Inject user Language instead of using context. Parameters

  
    User $user 
    IContextSource $context 
    array &$defaultPreferences 
    bool $canIPUseHTTPS Whether the user's IP is likely to be able to access the wiki via HTTPS. 
  
  

Returns
void

Member MediaWiki::returnSuccess ()

 When we drop support for Zend PHP 5, this can be removed. Returns
bool|int

Member MediaWiki::__construct (LoadBalancer $loadBalancer, SqlBlobStore $blobStore, WANObjectCache $cache, CommentStore $commentStore, ActorMigration $actorMigration, $wikiId=false)

$blobStore should be allowed to be any BlobStore!

Member MediaWiki::getRcIdIfUnpatrolled (RevisionRecord $rev)

This is overly specific, so move or kill this method.

Member MediaWiki::getRecentChange (RevisionRecord $rev, $flags=0)

move this somewhere else?

Member MediaWiki::loadRevisionFromId (IDatabase $db, $id)

remove when unused! there seem to be no callers of Revision::loadFromId

Member MediaWiki::loadRevisionFromPageId (IDatabase $db, $pageid, $id=0)

remove when unused!

Member MediaWiki::loadRevisionFromTimestamp (IDatabase $db, $title, $timestamp)

remove when unused!

Member MediaWiki::loadRevisionFromTitle (IDatabase $db, $title, $id=0)

remove when unused!

Member MediaWiki::newNullRevision (IDatabase $dbw, Title $title, CommentStoreComment $comment, $minor, User $user)

Introduce newFromParentRevision(). newNullRevision can then be based on that (or go away).

Member MediaWiki::compressData (&$blob)

make this private, there should be no need to use this method outside this class.

Member MediaWiki::decompressData ($blob, array $blobFlags)

make this private, there should be no need to use this method outside this class.

Member MediaWiki::expandBlob ($raw, $flags, $cacheKey=null)

make this private, there should be no need to use this method outside this class.

Member MediaWikiTitleCodec::splitTitleString ($text, $defaultNamespace=NS_MAIN)

this method is only exposed as a temporary measure to ease refactoring. It was copied with minimal changes from Title::secureAndSplit().

This method should be split up and an appropriate interface defined for use by the Title class.

Member MergeHistory::merge (User $user, $reason= '')

 if all versions of page A are moved to B and then a user tries to do a reverse-merge via the "unmerge" log link, then page A will still be a redirect (as it was after the original merge), though it will have the old revisions back from before (as expected). The user may have to "undo" the redirect manually to finish the "unmerge". Maybe this should delete redirects at the source page of merges?

Class MergeUserTest

this should use the Database group

Class Message


test, can we have tests?
this documentation needs to be extended

Member Message::isBlank ()

FIXME: Merge with isDisabled()?

Member MimeAnalyzer::getMediaType ($path=null, $mime=null)

analyse file if need be

look at multiple extension, separately and together.

Member MimeAnalyzer::isRecognizableExtension ($extension)

 Be more accurate when using fancy MIME detector plugins; right now this is the bare minimum getimagesize() list. Parameters

  
    string $extension 
  
  

Returns
bool

Member MovePageForm::doSubmit ()

FIXME: A specific error message should be given in this case.

File mwdocgen.php

document


Author
Antoine Musso <hashar at="" free="" dot="" fr>=""> 

Brion Vibber 

Alexandre Emsenhuber 
Version
first release

Member MWHttpRequest::setData ($args)

overload the args param

Member MWLBFactory::getLBFactoryClass (array $config)

instead of this, use a ServiceContainer for managing the different implementations.

Member MWNamespaceTest::testIsCapitalizedWithWgCapitalLinkOverrides ()

split groups of assertions in autonomous testing functions MWNamespace::isCapitalized

Member MWNamespaceTest::testIsMovable ()

Write more texts, handle $wgAllowImageMoving setting MWNamespace::isMovable

Class OldChangesListTest

 add tests to cover article link, timestamp, character difference, log entry, user tool links, direction marks, tags, rollback, watching users, and date header.

Class OutputPage

FIXME: Another class handles sending the whole page to the client.

document

Member OutputPage::disallowUserJs ()

this should be given a more accurate name

Class OutputPageTest

factor tests in this class into providers and test methods

Member PageArchive::listFiles ()

Does this belong in Image for fuller encapsulation?

Member Parser::setTransparentTagHook ($tag, callable $callback)

better document or deprecate this

Class ParserCache

document

Member ParserOutput::addTrackingCategory ($msg, $title)

Migrate some code to TrackingCategories

File ParserTestRunner.php

Make this more independent of the configuration (and if possible the database)

Member ParserTestRunner::setupDatabase ($nextTeardown=null)

: This is basically an unrefactored copy of MediaWikiTestCase::setupAllTestDBs. They should be factored out somehow.

Namespace PHPExcel

 Sort out xdebug in vagrant so that this works in all sandboxes For now, it is safer to test for it rather then remove it.

Member PHPExcel_Calculation_LookupRef::INDIRECT ($cellAddress=NULL, PHPExcel_Cell $pCell=NULL)

Support for the optional a1 parameter introduced in Excel 2010

Member PHPExcel_Calculation_Statistical::BINOMDIST ($value, $trials, $probability, $cumulative)

Cumulative distribution function

Member PHPExcel_Calculation_Statistical::CRITBINOM ($trials, $probability, $alpha)

 Warning. This implementation differs from the algorithm detailed on the MS web site in that $CumPGuessMinus1 = $CumPGuess - 1 rather than $CumPGuess - $PGuess This eliminates a potential endless loop error, but may have an adverse affect on the accuracy of the function (although all my tests have so far returned correct results).

Member PHPExcel_Calculation_Statistical::LOGINV ($probability, $mean, $stdDev)

 Try implementing P J Acklam's refinement algorithm for greater accuracy if I can get my head round the mathematics (as described at) http://home.online.no/~pjacklam/notes/invnorm/

Member PostgresUpdater::getCoreUpdateList ()

 FIXME: Postgres should use sequential updates like Mysql, Sqlite and everybody else. It never got refactored like it should've. Returns
array

Class Preprocessor_Hash

: Consider replacing descriptor arrays with objects of a new class. Benchmark and measure resulting memory impact.

Member ProtectionForm::show ($err=null)

FIXME: i18n issue, should use formatted number.

Member Psy::beforeTraverse (array $nodes)

 should this be final? Extending classes should be sure to either use afterTraverse or call parent::beforeTraverse() when overloading.

Member Psy::enterNode (Node $node)

 should this be final? Extending classes should be sure to either use leaveNode or call parent::enterNode() when overloading

Class Psy

 Detect constants defined in the current code snippet? ... Might not be worth it, since it would need to both be defining and referencing a namespaced constant, which doesn't seem like that big of a target for failure

Member Psy::formatException ( $e)

extract this to somewhere it makes more sense

Member Psy::writeVersionInfo ()

Implement self-update

Implement prompt to start update

Class Psy

handle assigning by reference

Member PurgeChangedPages::pageableSortedRows (ResultWrapper $res, $column, $limit)

move this elsewhere

File rebuildrecentchanges.php

Document

File rebuildtextindex.php

document

Class RecentChange

 Deprecate access to mAttribs (direct or via getAttributes). Right now we're having to include both rc_comment and rc_comment_text/rc_comment_data so random crap works right.

Member RemexHtml::consumeAttribs ()

: Make deferral configurable.

: Measure performance improvement, assess whether the LazyAttributes feature is warranted.

Member RenameAndMergeUserToStrLower::movePages (User $oOldUser, User $oNewUser)

This code is a duplicate of Renameuser and GlobalRename

Member ResourceLoader::getTestModuleNames ($framework= 'all')

api siteinfo prop testmodulenames modulenames

Member Revision::getContentFormat ()

: drop this, the format is irrelevant to the revision!

Member Revision::getContentModel ()

: drop this, with MCR, there no longer is a single model associated with a revision.

Member RevisionItem::getDiffLink ()

 Essentially a copy of RevDelRevisionItem::getDiffLink. That class should inherit from this one, and implement an appropriate interface instead of extending RevDelItem Returns
string

Member RevisionItem::getHTML ()

 Essentially a copy of RevDelRevisionItem::getHTML. That class should inherit from this one, and implement an appropriate interface instead of extending RevDelItem Returns
string

Member RevisionItem::getRevisionLink ()

 Essentially a copy of RevDelRevisionItem::getRevisionLink. That class should inherit from this one, and implement an appropriate interface instead of extending RevDelItem Returns
string

Member Sanitizer::escapeClass ($class)

For extra validity, input should be validated UTF-8.

Member Sanitizer::escapeIdReferenceList ($referenceString, $options=[])

remove $options completely in 1.32

Member Sanitizer::mergeAttributes ($a, $b)

 implement merging for other attributes such as style Parameters

  
    array $a 
    array $b 
  
  

Returns
array

Member Sanitizer::validateAttributes ($attribs, $whitelist)

Check for legal values where the DTD limits things.

Check for unique id attribute :P

Member Sanitizer::validateTagAttributes ($attribs, $element)

Check for legal values where the DTD limits things.

Check for unique id attribute :P

Class SanitizerTest

Tests covering decodeCharReferences can be refactored into a single method and dataprovider.

Class SanitizerValidateEmailTest

all test methods in this class should be refactored and... use a single test method and a single data provider...

Member Scribunto_LuaEngine::loadLibraryFromFile ($fileName)

: Clean up when support for MW < 1.27 is dropped

Member ScribuntoHooks::reportTiming ($moduleName, $functionName, $timing)

: Clean up when support for MW < 1.27 is dropped

Member SearchEngine::getTextFromContent (Title $t, Content $c=null)

 This isn't ideal, we'd really like to have content-specific handling here Parameters

  
    Title $t Title we're indexing 
    Content $c Content of the page to index 
  
  

Returns
string

Class SearchEngineDummy

FIXME: Dummy class should probably try something at least mildly useful, such as a LIKE search through titles.

Member SearchMssql::parseQuery ($filteredText, $fulltext)

 document Parameters

  
    string $filteredText 
    bool $fulltext 
  
  

Returns
string

Class SearchResult

FIXME: This class is horribly factored. It would probably be better to have a useful base class to which you pass some standard information, then let the fancy self-highlighters extend that.

File Setup.php

UGLY UGLY

Class SiteConfiguration

Give examples for, suffixes: $conf->suffixes = [ 'wiki' ]; localVHosts callbacks!

Member Skin::setupSkinUserCss (OutputPage $out)

delete

Member Skins::assertValidHTML ($actual, $message= '')

Currently only asserts that $actual is a string. Need to parse and validate,

Member Skins::assertTag ($matcher, $actual, $message= 'Failed asserting that the given fragment contained the described node.', $isHtml=true)

: Currently only supports 'tag' and 'class'

Member Skins::assertValidHTML ($actual, $message= 'HTML text is not valid. ')

Put this whole stuff in a and just call assertThat

Class SkinTemplate

 Needs some serious refactoring into functions that correspond to the computations individual esi snippets need. Most importantly no body parsing for most of those of course.

Member SkinTemplate::makeArticleUrlDetails ($name, $urlaction= '')

 is this even used? Parameters

  
    string $name 
    string $urlaction 
  
  

Returns
array

Member SMW::getCaptionFromDataItem (DITime $dataItem)

Internationalize the CE and BCE strings.

Member SMW::getRowListContent (array $row)

The inner lists of values per field should use different separators.

Some spaces are hard-coded here; should probably be part of separators.

Member SMW::parse (array $functionParams)

$rawParams should be of IParameterFormatter QueryParameterFormatter class

Member SMW::recache ($limit, $ignoreErrors=true)

Implement caching for SMW query pages

Member SMW::ping ($endpointType=self::EP_TYPE_QUERY)

 SPARQL endpoints sometimes return errors if no (valid) query is posted. The current implementation tries to catch this, but this might not be entirely correct. Especially, the SPARQL 1.1 HTTP error codes for Update are not defined yet (April 15 2011).

Member SMW::interpretDescription (Description $description)

 The case of nominal classes (top-level ValueDescription) still makes some assumptions about the table structure, especially about the name of the joinfield (o_id). Better extend compilePropertyValueDescription to deal with this case.

Member SMW::cleanUp ()

 I might be better to keep the tables and possibly reuse them later on. Being temporary, the tables will vanish with the session anyway.

Member SMWDIError::doUnserialize ($serialization)

 Be more careful with unserialization. It can create E_NOTICEs. Returns
SMWDIError

Member SMWDITime::__construct ($calendarmodel, $year, $month=false, $day=false, $hour=false, $minute=false, $second=false, $timezone=false)

Implement more validation here.

Member SMWDIUri::__construct ($scheme, $hierpart, $query, $fragment)

Implement more validation here.

Member SMWDIUri::getURI ()

This should be changed to the spelling getUri().

Member SMWExportController::printPages ($pages, $recursion=1, $revisiondate=false)

Consider dropping the $revisiondate filtering and all associated functionality. Is anybody using this?

Member SMWExporter::getOWLPropertyType ($type= '')

An improved mechanism for selecting property types here is needed.

Member SMWExporter::makeExportDataForSubject (SMWDIWikiPage $diWikiPage, $addStubData=false)

 Take into account whether the wiki page belongs to a builtin property, and ensure URI alignment/type declaration in this case.

Class SMWNumberValue

Wiki-HTML-conversion for unit strings must be revisited, as the current solution might be unsafe.

Member SMWPropertyValue::parseUserValue ($value)

Accept/enforce property namespace.

Member SMWQuery::setOffset ($offset)

 The function should be extended to take into account whether or not we are in inline mode (not critical, since offsets are usually not applicable inline).

Class SMWRecordValue

Enforce limitation of maximal number of values.

Enforce uniqueness of properties in declaration.

Complete internationalisation.

Member SMWRecordValue::checkAllowedValues ()

Allowed values for multi-valued properties are not supported yet.

Member SMWRecordValue::getPropertyDataItems ()

I18N for error message.

Member SMWRecordValue::setProperty (DIProperty $property)

 This is not a full reset yet (the case that property is changed after a value was set does not occur in the normal flow of things, hence this has low priority).

Member SMWSql3SmwIds::getPropertyInterwiki (SMWDIProperty $property)

 This documentation is out of date. Right now, the special interwiki is used only for special properties without a label, i.e., which cannot be shown to a user. This allows us to filter such cases from all queries that retrieve lists of properties. It should be checked that this is really the only use that this has throughout the code.

Member SMWSql3SmwIds::moveSubobjects ($oldtitle, $oldnamespace, $newtitle, $newnamespace)

This method is neither efficient nor very convincing architecturally; it should be redesigned.

Member SMWSQLStore3Readers::getPropertySubjects (SMWDIProperty $property, SMWDataItem $value=null, SMWRequestOptions $requestOptions=null)

This method cannot retrieve subjects for sortkeys, i.e., for property _SKEY. Only empty arrays will be returned there.

Member SMWSQLStore3Readers::getPropertyValues ($subject, SMWDIProperty $property, $requestOptions=null)

Retrieving all sortkeys (values for _SKEY with $subject null) is not supported. An empty array will be given.

Member SMWSQLStore3Writers::changeTitle (Title $oldTitle, Title $newTitle, $pageId, $redirectId=0)

 Currently the sortkey is not moved with the remaining data. It is not possible to move it reliably in all cases: we cannot distinguish an unset sortkey from one that was set to the name of oldtitle. Maybe use update jobs right away?

Member SMWSQLStore3Writers::updateRedirects ($subject_t, $subject_ns, $curtarget_t= '', $curtarget_ns=-1)

Clean up this code.

Member SMWStringValue::getLongHTMLText ($linker=null)

 Rather parse input to obtain properly formatted HTML. See Also
DataValue::getLongHTMLText

Class SMWTimeValue

Theparsing process can encounter many kinds of well-defined problems but uses only one error message. More detailed reporting should be done.

Try to reuse more of MediaWiki's records, e.g. to obtain month names or to format dates. The problem is that MW is based on SIO timestamps that don't extend to very ancient or future dates, and that MW uses PHP functions that are bound to UNIX time.

Member SMWTimeValue::getWikiValue ()

 The preferred caption may not be suitable as a wiki value (i.e. not parsable). See Also
SMWDataValue::getLongHTMLText

Member SMWTimeValue::parseDateString ($string, &$datecomponents, &$calendarmodel, &$era, &$hours, &$minutes, &$seconds, &$microseconds, &$timeoffset, &$timezone)

This method in principle allows date parsing to be internationalized further. Should be done.

Class SpecialAllPages

Rewrite using IndexPager

Member SpecialBlock::getSuggestedDurations ($lang=null)

 FIXME: This uses a rather odd syntax for the options, should it be converted to the standard "**<duration>|<displayname>" format? Parameters

  
    Language | null $lang The language to get the durations in, or null to use the wiki's content language 
  
  

Returns
array

Member SpecialBlock::getTargetAndType ($par, WebRequest $request=null)

 Should be in Block.php? Parameters

  
    string $par Subpage parameter passed to setup, or data value from the HTMLForm 
    WebRequest $request Optionally try and get data from a request too 
  
  

Returns
array [ User|string|null, Block::TYPE_ constant|null ]

Member SpecialBlock::parseExpiryInput ($expiry)

 strtotime() only accepts English strings. This means the expiry input can only be specified in English. See Also
https://secure.php.net/manual/en/function.strtotime.php

Member SpecialContributions::contributionsSub ($userObj)

FIXME: Almost the same as getSubTitle in SpecialDeletedContributions.php. Could be combined.

Member SpecialExport::execute ($par)

FIXME: This can lead to hitting memory limit for very large categories. Ideally we would do the lookup synchronously during the export in a single query.

Member SpecialMergeHistory::merge ()

 if all versions of page A are moved to B and then a user tries to do a reverse-merge via the "unmerge" log link, then page A will still be a redirect (as it was after the original merge), though it will have the old revisions back from before (as expected). The user may have to "undo" the redirect manually to finish the "unmerge". Maybe this should delete redirects at the target page of merges?

Member SpecialPreferencesTest::testBug41337 ()

give this test a real name explaining what is being tested here

Member SpecialReplaceText::extractContext ($text, $target, $use_regex=false)

The bolding needs to be fixed for regular expressions.

Member SpecialRevisionDelete::addUsageText ()

FIXME: Wikimedia-specific policy text

Member SpecialRevisionDelete::tryShowFile ($archiveName)

 Mostly copied from Special:Undelete. Refactor. Parameters

  
    string $archiveName 
  
  

Exceptions

  
    MWException 
    PermissionsError

Member SpecialUpload::rotationEnabled ()

 What about non-BitmapHandler handled files? Returns
bool

File SpecialWhatlinkshere.php

Use some variant of Pager or something; the pagination here is lousy.

Member SRFArray::getResultText (SMWQueryResult $res, $outputmode)

 Is there some other way to check the data value directly for being the page title or not? SMWs behavior could change on mainlabel handling...

Member SRFCalendar::getResultText (SMWQueryResult $res, $outputmode)

Split up megamoth

Class StripState

document, briefly.

Class SwiftVirtualRESTService

 caching support (APC/memcached) Since
1.23

Group TermColorer

Fixme: Make this more generic

Member TestUserRegistry::isMutable (User $user)

It would be nice if this were a non-static method of TestUser instead, but that doesn't seem possible without friends?

Member Title::getBrokenLinksFrom ()

 check if needed (used only in SpecialBrokenRedirects.php, and should use redirect table in this case). Returns
Title[] Array of Title the Title objects

Member Title::getUserPermissionsErrors ($action, $user, $rigor= 'secure', $ignoreErrors=[])

FIXME: This does not check throttles (User::pingLimiter()).

Member Title::validateFileMoveOperation ($nt)

 move this to MovePage Parameters

  
    Title $nt Target title 
  
  

Returns
array List of errors

Member TitleFormatter::getNamespaceName ($namespace, $text)

Move this to a separate interface

Member TitlePermissionTest::testActionPermissions ()

This test method should be split up into separate test methods and data providers Title::checkActionPermissions

Member TitlePermissionTest::testCssConfigEditPermissions ()